opensearch-project / dashboards-observability

Visualize and explore your logs, traces and metrics data in OpenSearch Dashboards
https://opensearch.org/docs/latest/observability-plugin/index/
Apache License 2.0
16 stars 55 forks source link

[Feature] Traces/Services UI update #2078

Closed TackAdam closed 2 months ago

TackAdam commented 3 months ago

Description

  1. Updates Traces UI to conform with the header changes.
  2. Updates Services UI to conform with the header changes.
  3. Fixes a bug with the global filter icon where it would get stuck open if double clicked.

Traces before:

Screenshot 2024-08-20 at 3 17 08 PM

After:

Screenshot 2024-08-21 at 9 35 58 PM

Services before:

Screenshot 2024-08-20 at 3 17 32 PM

After:

Screenshot 2024-08-21 at 9 35 34 PM

Fix to filter button - now closes when re-clicked or an option is selected.

Screenshot 2024-08-20 at 3 20 37 PM

These changes to UI required the filter to be broken apart. Video showing it still works while separated:

https://github.com/user-attachments/assets/734f1b15-b09e-4c53-862f-fc67eaf648a8

Issues Resolved

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot[bot] commented 2 months ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2078-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 de3acb06378334cc61714bf4d95fc7602ecf9714
# Push it to GitHub
git push --set-upstream origin backport/backport-2078-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2078-to-2.x.