opensearch-project / dashboards-observability

Visualize and explore your logs, traces and metrics data in OpenSearch Dashboards
https://opensearch.org/docs/latest/observability-plugin/index/
Apache License 2.0
14 stars 52 forks source link

Trace Analytics support for custom sources #2112

Closed ps48 closed 3 weeks ago

ps48 commented 3 weeks ago

Description

Experimental feature for Trace Analytics support of custom sources

Issues Resolved

2052

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

TackAdam commented 3 weeks ago

UI looks correct / functional under the new navigation.

Screenshot 2024-09-03 at 6 41 35 PM
TackAdam commented 3 weeks ago
Screenshot 2024-09-03 at 6 35 58 PM

Under the new navigation when services and traces are broken apart, do we need to change this drop down for services?

TackAdam commented 3 weeks ago
Screenshot 2024-09-03 at 6 44 08 PM

Spacing seems a little off between the drop downs. Not sure if we have a reference for multiple bars. Not blocking.

ps48 commented 3 weeks ago

@TackAdam @RyanL1997 Thanks for the review.

Spacing seems a little off between the drop downs. Not sure if we have a reference for multiple bars.

  • Updated spacing for flex items Screenshot 2024-09-03 at 9 42 05 PM

Under the new navigation when services and traces are broken apart, do we need to change this drop down for services?

  • Changed it to custom source
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 36.18234% with 224 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (c3ab50f) to head (850a8c8). Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
.../components/traces/traces_custom_indices_table.tsx 0.00% 69 Missing :warning:
...trace_analytics/requests/traces_request_handler.ts 15.38% 33 Missing :warning:
...ace_analytics/components/traces/traces_content.tsx 45.23% 22 Missing and 1 partial :warning:
...race_analytics/components/traces/services_list.tsx 4.76% 20 Missing :warning:
...nalytics/components/common/custom_index_flyout.tsx 46.87% 17 Missing :warning:
...e_analytics/components/common/helper_functions.tsx 66.66% 10 Missing :warning:
...trace_analytics/requests/queries/traces_queries.ts 41.17% 10 Missing :warning:
..._analytics/components/common/plots/service_map.tsx 50.00% 8 Missing :warning:
...ace_analytics/components/services/service_view.tsx 33.33% 8 Missing :warning:
...analytics/components/traces/span_detail_flyout.tsx 42.85% 7 Missing and 1 partial :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2112 +/- ## ========================================== - Coverage 57.85% 56.59% -1.26% ========================================== Files 372 389 +17 Lines 14081 14938 +857 Branches 3712 4049 +337 ========================================== + Hits 8146 8454 +308 - Misses 5871 6422 +551 + Partials 64 62 -2 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/dashboards-observability/pull/2112/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [dashboards-observability](https://app.codecov.io/gh/opensearch-project/dashboards-observability/pull/2112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `56.59% <36.18%> (-1.26%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

opensearch-trigger-bot[bot] commented 3 weeks ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2112-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ec67ad1ce6a6d20c0e316a09488d907161931472
# Push it to GitHub
git push --set-upstream origin backport/backport-2112-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2112-to-2.x.

opensearch-trigger-bot[bot] commented 3 weeks ago

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.17
# Create a new branch
git switch --create backport/backport-2112-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ec67ad1ce6a6d20c0e316a09488d907161931472
# Push it to GitHub
git push --set-upstream origin backport/backport-2112-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-2112-to-2.17.