opensearch-project / dashboards-query-workbench

The OpenSearch Dashboards Query Workbench enables you to query your OpenSearch data using either SQL or PPL
Apache License 2.0
7 stars 30 forks source link

Add workflow to verify binary install #272

Closed derek-ho closed 7 months ago

derek-ho commented 7 months ago

Description

I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR.

Related issues: https://github.com/opensearch-project/security-dashboards-plugin/issues/1709 https://github.com/opensearch-project/security-analytics-dashboards-plugin/pull/875 https://github.com/opensearch-project/dashboards-observability/pull/309 https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5952

Issues Resolved

[List any issues this PR will resolve]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.88%. Comparing base (9188921) to head (026389b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #272 +/- ## ======================================= Coverage 59.88% 59.88% ======================================= Files 33 33 Lines 1623 1623 Branches 288 288 ======================================= Hits 972 972 Misses 548 548 Partials 103 103 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/dashboards-query-workbench/pull/272/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [dashboards-query-workbench](https://app.codecov.io/gh/opensearch-project/dashboards-query-workbench/pull/272/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `59.88% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

derek-ho commented 7 months ago

Workflow is green, merging