search

opensearch-project / dashboards-query-workbench

The OpenSearch Dashboards Query Workbench enables you to query your OpenSearch data using either SQL or PPL
Apache License 2.0
4 stars 28 forks source link

[Backport 2.x] Add OSD react as required plugin #279

Closed opensearch-trigger-bot[bot] closed 4 months ago

opensearch-trigger-bot[bot] commented 4 months ago

Backport 7b35161d7ccceeaefe093ebdfe8101892e435586 from #278.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.47%. Comparing base (aba5f7e) to head (a7be225). Report is 3 commits behind head on 2.x.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x #279 +/- ## ========================================== + Coverage 59.88% 61.47% +1.58% ========================================== Files 33 33 Lines 1623 1599 -24 Branches 288 284 -4 ========================================== + Hits 972 983 +11 + Misses 548 518 -30 + Partials 103 98 -5 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/dashboards-query-workbench/pull/279/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [dashboards-query-workbench](https://app.codecov.io/gh/opensearch-project/dashboards-query-workbench/pull/279/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `61.47% <ø> (+1.58%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ps48 commented 4 months ago

@derek-ho Can do a check in the workflow that we run the CI only if artifact exists?

derek-ho commented 4 months ago

That's a good idea - I created an issue: https://github.com/derek-ho/setup-opensearch-dashboards/issues/2. I will try to follow up soon and bump the version of the action used in other repos so they aren't blocked on this. Will try to circle around to this repo as well, but hopefully we have min artifacts soon.