opensearch-project / dashboards-query-workbench

The OpenSearch Dashboards Query Workbench enables you to query your OpenSearch data using either SQL or PPL
Apache License 2.0
4 stars 28 forks source link

Adjusting Create Acceleration Flyout Props #289

Closed sejli closed 3 months ago

sejli commented 3 months ago

Description

Draft PR for some questions

Issues Resolved

N/A

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.49%. Comparing base (d168db7) to head (1587571).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #289 +/- ## ========================================== + Coverage 59.34% 59.49% +0.14% ========================================== Files 39 40 +1 Lines 1835 1844 +9 Branches 328 328 ========================================== + Hits 1089 1097 +8 - Misses 633 634 +1 Partials 113 113 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/dashboards-query-workbench/pull/289/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [dashboards-query-workbench](https://app.codecov.io/gh/opensearch-project/dashboards-query-workbench/pull/289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `59.49% <ø> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sejli commented 3 months ago

Fixing with #1598