opensearch-project / dashboards-query-workbench

The OpenSearch Dashboards Query Workbench enables you to query your OpenSearch data using either SQL or PPL
Apache License 2.0
7 stars 31 forks source link

[BUG]Accelerate Table Flyout not working(Flint Datasource) -expecting dataSourceType #348

Open TackAdam opened 4 months ago

TackAdam commented 4 months ago

What is the bug? For Flint datasources. the "Accelerate Table" flyout button opens a blank page due to dataSourceType being undefined. This is introduced by https://github.com/opensearch-project/dashboards-observability/commit/19d68b2d443458c3fdb1bd0fe035bf823111015b And is shown here https://github.com/opensearch-project/dashboards-observability/blob/b328720c11811d45da9d0594c5c28a18dd8fa2d0/public/components/datasources/components/manage/accelerations/create_accelerations_flyout/selectors/index_type_selector.tsx#L27

How can one reproduce the bug?

  1. Go to queryWorkBench and switch to a Flint data source.
  2. Click on Accelerate Table
  3. The flyout will be blank. Screenshot 2024-07-11 at 2 54 14 PM
Screenshot 2024-07-11 at 2 56 05 PM Screenshot 2024-07-11 at 2 53 58 PM

What is the expected behavior? Using a commit prior to this for dashboards-observability such as https://github.com/opensearch-project/dashboards-observability/commit/e5af7eb55f44f8c32c43ee7a86099619e98448b7 works as intended

https://github.com/user-attachments/assets/2dd14f62-0025-4786-8de8-8d0c36ce6b4c

What is your host/environment?

Do you have any additional context? queryWorkBench does not pass a dataSourceType and the undefined behavior will cause the flyout to fail.

dblock commented 4 months ago

[Catch All Triage - 1, 2, 3, 4]