opensearch-project / dashboards-query-workbench

The OpenSearch Dashboards Query Workbench enables you to query your OpenSearch data using either SQL or PPL
Apache License 2.0
7 stars 31 forks source link

[Bug] Fix url redirection, add default render path #387

Closed TackAdam closed 2 months ago

TackAdam commented 2 months ago

Description

  1. Fix url redirection
  2. Add default render path when there is basePath closing : https://github.com/opensearch-project/dashboards-query-workbench/pull/381 (Support for dev tools under modal pop out) As we will make dev tools as a full page modal when new nav toggle is turned on, we will use MemoryRouter to replace HashRouter in our page to avoid modifying the hosted page' hash. And this change will impact search relevance functionality. And this PR adds a default path when there is no '/' route. For more details please take a look on the comment: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7938#discussion_r1738383931.

Tested url paths: path={/${basePath}/:dataSource} path={/${basePath}/accelerate/:dataSource} path="/" path={/${basePath}}

Old Navigation:

https://github.com/user-attachments/assets/128c154d-e4be-4ab8-ba19-3f974306b010

New Navigation:

https://github.com/user-attachments/assets/5b225238-e4e9-4181-a020-58b89981261a

New Navigation + https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7938 modal applied.

https://github.com/user-attachments/assets/592fd5ff-78c7-4e3f-91f5-349fe3aaf14a

Issues Resolved

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48 commented 2 months ago

Thanks @TackAdam for the bug fix 🥳