opensearch-project / data-prepper

OpenSearch Data Prepper is a component of the OpenSearch project that accepts, filters, transforms, enriches, and routes data at scale.
https://opensearch.org/docs/latest/clients/data-prepper/index/
Apache License 2.0
262 stars 201 forks source link

Add exemplars into metrics generated for ingesting traces #2456

Open derek-ho opened 1 year ago

derek-ho commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. It would be nice to have [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered (Optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

dlvenable commented 1 year ago

@derek-ho , I think supporting exemplars would be a great feature. Do you have a specific goal in mind? Or an expected outcome from Data Prepper?

derek-ho commented 1 year ago

@dlvenable I had in mind that for the metrics index created from the trace ingestion pipeline we can populate the graph with specific points/traceIds, that can then link into the trace analytics feature - connecting metrics with traces in an easier way - I wanted to take up some initial work, but I have to finish up a few tasks this week/next few days - does the feature request make sense?

dlvenable commented 1 year ago

Yes, I think that including exemplars in the model to send to OpenSearch makes sense.

Data Prepper has the ability to generate metrics from traces. And it has the ability to receive OTel metrics via gRPC. Are you expecting to have exemplars for both scenarios? Or a specific scenario?

derek-ho commented 1 year ago

@dlvenable I talked briefly with Krishna about this, he suggested of the following types:

  1. metrics passed through DataPrepper
  2. metrics generated by DataPrepper

To start with the former as the latter uses the former. I think I will start with that, thoughts?