Open retoo opened 2 years ago
Could you explain a bit why the current naming scheme is causing problems for you?
It just creates super long PVC names. Lets say I name my cluster opensearch-myapp-integration
, this leads to both the claim-template and the statefulset to be called: opensearch-myapp-integration-master
(the groupname master
gets appended).
When a statefulset scales up, it looks for a claim named: $CLAIM_TEMPLATE_NAME-$STATEFULSET_NAME-{0..N}
Meaning, it will create a PVC named: opensearch-myapp-integration-master-opensearch-myapp-integration-master-0
which is both ridiculous long (74 chars) ;)
The claimTemplate name just need to be unique within one statefulset, other vendors name the template data
, which for example would lead to data-$CLUSTER_NAME-master-0
.
Unfortunately it is not possible to change the pvc name now, it probably would break old setup, hence the override for people like me with long names ;).
tldr Ugly long names, possible break k8s identifier limit.
If this is something which is really impacting users of the chart, then I don't have any strong opinions for this change. We can keep the default value and give a facility for configuring it.
I agree, the PVC names are very long, which causes them to be truncated in our monitoring/logging dashboards. A way to overwrite the names would be very helpful in my opinion.
Is your feature request related to a problem? Please describe. The current volumeClaimTemplate name is rather long, currently the name
opensearch.uname
being used. The problem is, that this leads to really long PVC names, i.e. if yourclusterName
isopensearch-test
then yourvolumeClaimTemplate
will beopensearch-test-master
which leads to the pvc nameopensearch-test-master-opensearch-test-master-0
Describe the solution you'd like The name itself probably cannot be changed without breaking old installations. Therefore we should make the name itself configurable.