search

opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

Support ipFamilyPolicy on services #375

Closed UXabre closed 1 year ago

UXabre commented 1 year ago

Signed-off-by: Arend Lapere arend.lapere@gmail.com

Description

Add the ability to set a service as being a dual stack service for both dashboard as cluster.

Issues Resolved

Check List

For any changes to files within Helm chart directories:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jordarlu commented 1 year ago

Thanks for the PR, we will review it and get back to you. Thanks!!

UXabre commented 1 year ago

Hi, I've added a check to see if ipFamilyPolicy is set, not setting it reverts to following the CNI defaults instead (so is the most compatible way imaginable). I've also included a commit with the ipFamilies field, this gives the most versatility to this PR. If you want, I can squash this into one commit to not pollute the git log.

UXabre commented 1 year ago

Hi @TheAlgo , there is (some) documentation in the values file, do you want me to further elaborate in the values files or where would you like some more documentation? :-)

prudhvigodithi commented 1 year ago

Hey @UXabre thanks for the contribution, documentation is the readme file, can you please update this. Thank you

peterzhuamazon commented 1 year ago

Hi @prudhvigodithi seems like @UXabre has updated the PR. Let us review this again now?

Thanks.

UXabre commented 1 year ago

Hi, I've added the options to the readme as well as a link to the official k8s documentation regarding this. Also had to resolve some merge conflicts :-)

TheAlgo commented 1 year ago

@prudhvigodithi Lets get this to closure whenever you are free. Thanks

prudhvigodithi commented 1 year ago

Thanks @UXabre merged this PR, can you please backport this change to 1.x branch? Thank you

UXabre commented 1 year ago

OK, will make a PR soon for the backport

peterzhuamazon commented 1 year ago

OK, will make a PR soon for the backport

Hi @UXabre any progress on the backport? Thanks.

peterzhuamazon commented 1 year ago

I backport it: