opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

[Enhancement][opensearch] Allow user-defined labels on ingress resource #394

Closed jwitko closed 1 year ago

jwitko commented 1 year ago

Is your feature request related to a problem? Please describe. I am using external-dns with settings that makes it label-driven instead of annotation-driven. Because opensearch does not allow me to add user-defined labels to the ingress I cannot get external-dns to pick up the opensearch ingress and automatically create a DNS entry for the endpoint.

Describe the solution you'd like I would like to be able to add user-defined labels in a similar fashion as annotations to the ingress resource created by the helm chart.

Describe alternatives you've considered N/A

prudhvigodithi commented 1 year ago

Hey @jwitko thanks for raising an issue, I see your problem, this should be an easy fix, just like how it was added to service labels, we should add the same way to ingress and then you can pass the external-dns label that can added to ingress file, are you open to raise a PR? Thank you @bbarani @rishabh6788

jwitko commented 1 year ago

@prudhvigodithi I already created the PR. It is attached to this Issue linked above. #390

prudhvigodithi commented 1 year ago

Thanks @jwitko I will take a look.