opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

[Enhancement][opensearch] Allow overriding affinity definition #397

Closed DCCSKrezovic closed 9 months ago

DCCSKrezovic commented 1 year ago

Is your feature request related to a problem? Please describe.

It is currently only possible to configure affinity as "soft" or "hard". But it's not possible to add additional affinity rules, i.e to avoid scheduling on nodes with other resource intensive pods

Describe the solution you'd like

To specify my own affinity rules.

prudhvigodithi commented 1 year ago

[Triage] Thanks @DCCSKrezovic for raising an issue, can you please contribute to the chart based on existing chart settings? Thank you @bbarani @rishabh6788

emmahsax commented 11 months ago

Would be very helpful to be able to set our own affinity rules.

prudhvigodithi commented 11 months ago

Hey @emmahsax , @premkirank can you please take a look and see if you can contribute?

emmahsax commented 11 months ago

@prudhvigodithi We are already working on a fork that allows this. We are also interested in allowing passing of custom anti-affinity, AKA not being required to use one of the two hard and soft options provided. We're doing our best to make it a non-breaking change so it could theoretically be merged into upstream.

prudhvigodithi commented 11 months ago

Hey @emmahsax once you have a PR, please raise it against https://github.com/opensearch-project/helm-charts/, I can test your change, review and get it merged. Thanks

emmahsax commented 11 months ago

@prudhvigodithi Here's that PR: https://github.com/opensearch-project/helm-charts/pull/495!