opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
173 stars 234 forks source link

Add imagePullPolicy to init container #417

Closed jadams closed 1 year ago

jadams commented 1 year ago

Signed-off-by: John Adams <>

Description

Add imagePullPolicy to fsgroup-volume init container (also remove trailing whitespace in this file)

Issues Resolved

Issue not filed, but breaks startup of Opensearch when no internet connection is available but container is cached

Check List

For any changes to files within Helm chart directories:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

gentoo9ball commented 1 year ago

Need this merged as well, thank you

TheAlgo commented 1 year ago

Hi @gentoo9ball

Thanks a lot for your contribution. Welcome to OpenSearch community. For this PR can you please create and issue and attach a link to the PR. I can take a look at this PR post that.

gentoo9ball commented 1 year ago

Hi @gentoo9ball

Thanks a lot for your contribution. Welcome to OpenSearch community. For this PR can you please create and issue and attach a link to the PR. I can take a look at this PR post that.

Done, #420 Thanks!

prudhvigodithi commented 1 year ago

Hey @jadams can you please check the tests, I see they are failing. @TheAlgo can you please review this? Thank you @bbarani @peterzhuamazon

jadams commented 1 year ago

@TheAlgo version bumped to match current main

TheAlgo commented 1 year ago

@prudhvigodithi @peterzhuamazon Can you guys please take a look?

prudhvigodithi commented 1 year ago

Thanks @jadams LGTM? Can you please backport this PR to 1.x?