opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

Use the loop variable in keystore init script #444

Closed uncycler closed 1 year ago

uncycler commented 1 year ago

Description

The keystore init script use an undeclared variable instead of the loop (i) variable to check the file existence.

Check List

For any changes to files within Helm chart directories:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

hobti01 commented 1 year ago

you are faster than me :)

prudhvigodithi commented 1 year ago

Hey @hobti01 and @uncycler does this PR fix this issue https://github.com/opensearch-project/helm-charts/issues/446 ?

prudhvigodithi commented 1 year ago

@uncycler thanks a lot for the contribution, closing this PR in favor of https://github.com/opensearch-project/helm-charts/pull/445.