search

opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

[BUG][Opensearch] ExtraManifests do not allow structured data #463

Closed Nickmman closed 1 year ago

Nickmman commented 1 year ago

Describe the bug extraManifests in templates should allow structured data input, for better readability and will allow for text editors to properly check for syntax errors.

To Reproduce Steps to reproduce the behavior:

  1. Deploy a Secret via ExtraObjects
  2. Have the Secret use StringData
  3. StringData should be structured as a normal secret
  4. Obtain error "expected string, got &value.valueUnstructured"

Expected behavior Objects should be created whether they are structured or not, when added properly.

Chart Name Opensearch

Screenshots None available.

Host/Environment (please complete the following information):

Additional context Will provide proposed changes via a linked PR.

TheAlgo commented 1 year ago

Thanks @Nickmman for creating the PR. Much appreciated.

Nickmman commented 1 year ago

Ended up going a different route for this, with custom logic outside of the chart. Closing.

pierluigilenoci commented 4 months ago

FYI https://github.com/helm/helm/issues/12653