Allow overriding of `pathType` in ingress rules to support ImplementationSpecific

seveneves commented 1 year ago

Description

Depending on implementation of ingressClass, hardcoded value Prefix for pathType of rules won't work and ImplementationSpecific should be specified instead.

This change adds a new parameter for both helm charts for opensearch and opensearch-dashboards

opensearch adds pathType: Prefix along with the existing path: / in value.yaml
opensearch-dashboards adds pathType: Prefix in ingress.hosts.paths array and defaults to Prefix in the template ingress.yaml and the default rule specified in values.yaml.

Issues Resolved

No issue created

Check List

[x] Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

[x] Helm chart version bumped
[x] Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

bbarani commented 10 months ago

@peterzhuamazon @prudhvigodithi @TheAlgo Can you please review this PR and provide your feedback?

duartesaraiva98 commented 4 months ago

@bbarani @peterzhuamazon @prudhvigodithi @TheAlgo

Hi, this PR has been open for a while now, is there any way we can progress with it?

Thanks in advance

opensearch-project / helm-charts