Closed premkirank closed 11 months ago
@premkirank can you please take a look at this comment. Thanks
@premkirank can you please take a look at this comment. Thanks
@prudhvigodithi I had rebased my PR and requested a review again. Is there anything else that I have missed?
Thanks, the CI tests fail can you please take care of it @premkirank ?
@prudhvigodithi I am not able to understand why the tests are failing. Please help here.
@premkirank You have updated the
appVersion
to2.12
and we don't have a version of OpenSearch yet. Can you revert this to2.11
. You only need to update chart version and not app version.
@TheAlgo @prudhvigodithi have reverted the app version
@prudhvigodithi Please do have a look when free. Thanks
Thanks @TheAlgo, @premkirank can you please backport this to 1.x branch as well? this is for the OpenSearch 1.x series. Thank you
Thanks @TheAlgo, @premkirank can you please backport this to 1.x branch as well? this is for the OpenSearch 1.x series. Thank you
@prudhvigodithi Here is the backport PR - https://github.com/opensearch-project/helm-charts/pull/491
Description
Added a
description
for the lifecycle parameter in READMEIssues Resolved
Fixes https://github.com/opensearch-project/helm-charts/issues/459
Check List
For any changes to files within Helm chart directories:
CHANGELOG.md
updated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.