search

opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

Allow passing in custom pod anti-affinity, as well as pod affinity #495

Closed emmahsax closed 9 months ago

emmahsax commented 11 months ago

Description

This change allows people to pass in both pod affinity as well as custom pod anti-affinity (which will ignore the default hard and soft anti-affinity currently present in this helm chart).

To use the customAntiAffinity, antiAffinity must be set to custom, otherwise the default soft affinity will be used. If antiAffinity is set to custom, but nothing is specified in customAntiAffinity, then {} will be used for anti-affinity.

Issues Resolved

This change will resolve https://github.com/opensearch-project/helm-charts/issues/397.

Check List

For any changes to files within Helm chart directories:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

emmahsax commented 11 months ago

I'm not sure if I'm supposed to manually update the CHANGELOG.md, or if that's auto-generated. If it needs to be manual, let me know and I can update that.

prudhvigodithi commented 9 months ago

Hey @emmahsax, apologies for the delay, yes the changelog needs to be updated? Here is the sample merged Pull request https://github.com/opensearch-project/helm-charts/pull/482/files.

emmahsax commented 9 months ago

@prudhvigodithi Thanks. The Changelog is updated. I also synced my branch with the latest from main so that it updates to a newer version.

prudhvigodithi commented 9 months ago

Thanks @emmahsax, Since this is a not the OpenSerach version upgrade can you please change this to 2.17.1 (I will try to document this versioning in the contribution guidelines as well). Also please update the [Unreleased] section in the changelog file, example https://github.com/opensearch-project/helm-charts/pull/506/files.

emmahsax commented 9 months ago

@prudhvigodithi Thanks! Complete.

prudhvigodithi commented 9 months ago

LGTM. @TheAlgo @peterzhuamazon can you please check?