opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

Add user-defined labels option to ingress #497

Closed wigust closed 9 months ago

wigust commented 11 months ago

Description

Similar to #390 allow to add labels to Ingress in charts/opensearch

Issues Resolved

Labels could be used in kube-prometheus-stack monitoring.coreos.com/v1 Probe objects as a selector.

Check List

For any changes to files within Helm chart directories:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

prudhvigodithi commented 9 months ago

Thanks LGTM, final two things left is please update the chart README section adding ingress. ingressLabels and the changelog [Unreleased] section, here is the sample merged PR https://github.com/opensearch-project/helm-charts/pull/506/files.

prudhvigodithi commented 9 months ago

I will take care of this suggestions from my above comment, we can merge this PR.

prudhvigodithi commented 9 months ago

Hey @wigust in order to fast-track I have pushed a commit with updated chart version and a conflict fix. Adding @TheAlgo