Closed wigust closed 9 months ago
Thanks LGTM, final two things left is please update the chart README section adding ingress. ingressLabels
and the changelog [Unreleased]
section, here is the sample merged PR https://github.com/opensearch-project/helm-charts/pull/506/files.
I will take care of this suggestions from my above comment, we can merge this PR.
Hey @wigust in order to fast-track I have pushed a commit with updated chart version and a conflict fix. Adding @TheAlgo
Description
Similar to #390 allow to add labels to Ingress in charts/opensearch
Issues Resolved
Labels could be used in kube-prometheus-stack monitoring.coreos.com/v1 Probe objects as a selector.
Check List
For any changes to files within Helm chart directories:
CHANGELOG.md
updated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.