search

opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

[Enhancement][opensearch] Allow user-defined labels on ingress resource #498

Closed wigust closed 5 months ago

wigust commented 11 months ago

Is your feature request related to a problem? Please describe. The Prometheus Operator allows to create Probes objects automatically for all Ingress objects. The OpenSearch API requires authentication on / and returns 401, which triggers alerts by default (not HTTP code 200-399).

Describe the solution you'd like Labels could be used in kube-prometheus-stack monitoring.coreos.com/v1 Probe objects as a selector to disable creating probe for the OpenSearch Ingress.

Describe alternatives you've considered Configure Blackbox exporter for authenticated connections to OpenSearch API.

Additional context Similar to #394 Ingress labels could be used for other things, e.g. external-dns.

Pull request adding this feature is available at https://github.com/opensearch-project/helm-charts/pull/497

opencmit2 commented 10 months ago

Hi @wigust The configuration .Values.labels can also be used to add custom labels.

wigust commented 9 months ago

Hi @opencmit2

Apologies for the slow response.

The configuration .Values.labels can also be used to add custom labels.

It can, but as described in the pull request - it triggers to restart all OpenSearch pods which is too costly for the case of adding a label to ingress.

wigust commented 5 months ago

Merged in #497

Thank you for adding this feature!