Updates HELM configuration to adapt to changes in demo admin user setup and bumps appVersion to 2.12.0

[DarshitChanpura]

Description

This change adapts to the change in security plugin's demo installation script which now requires admin password to be setup when installing demo configuration. Without this password, the cluster will not spin up.

Issues Resolved

• Related to https://github.com/opensearch-project/security/issues/3711

Check List

• [x] Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

• [ ] Helm chart version bumped
• [ ] Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[DarshitChanpura]

~@prudhvigodithi to add changes to support for initialAdminPassword.txt~

Update: security plugin is not supporting password via txt file and hence this is not required.

[DarshitChanpura]

@prudhvigodithi @ruanyl Can I get more reviews on this?

[DarshitChanpura]

@prudhvigodithi Could you please review this?

[DarshitChanpura]

@prudhvigodithi Could you please add 1 more review?

[prudhvigodithi]

Thanks @DarshitChanpura, this PR should be merged after 2.12.0 release because it clearly said 2.18.0 requires OPENSEARCH_INITIAL_ADMIN_PASSWORD which is not the case if we merge this PR today. So I would suggest to hold on this PR and merge it with 2.12.0 release. Also since this OPENSEARCH_INITIAL_ADMIN_PASSWORD is a mandatory option for new users, the extraEnvs are optional so this might get lost.

I would suggest to use a new parameter as initialAdminPassword in values.yaml (example https://github.com/opensearch-project/helm-charts/blob/main/charts/opensearch/values.yaml#L3) and backend in statefulset pass this as ENV.

With your change can you please test adding a keystore: [] and enabling masterTerminationFix? because if uses the password with these options.

Thanks

[DarshitChanpura]

I would suggest to use a new parameter as initialAdminPassword in values.yaml (example https://github.com/opensearch-project/helm-charts/blob/main/charts/opensearch/values.yaml#L3) and backend in statefulset pass this as ENV. With your change can you please test adding a keystore: [] and enabling masterTerminationFix? because if uses the password with these options.

@prudhvigodithi I'm unfamiliar with HELM and hence slightly confused at what the ask is here. We are not supplying a default password. User will always have to pass the password. Our intention is to fail cluster startup if no password was supplied. By adding a new parameter "initialAdminPassword" we are essentially supplying a default value. We are moving away from default hardcoded password for admin.

[prudhvigodithi]

Thanks @DarshitChanpura for your contribution, there are some more changes required, I'm closing this PR in favor of https://github.com/opensearch-project/helm-charts/pull/518.