feat: Add initial version of data-prepper helm chart

opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.

https://opensearch.org/docs/latest/opensearch/install/helm/

Apache License 2.0

170 stars 228 forks source link

feat: Add initial version of data-prepper helm chart #547

Closed SergK closed 3 months ago

SergK commented 4 months ago

Description

Let's start with the initial version of the data-prepper. We can extend it later with more examples of configuration

Issues Resolved

Related issue: #45

Check List

[x] Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

[x] Helm chart version bumped
[ ] Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

SergK commented 3 months ago

Hello @TheAlgo, any chance to push this forward?

ruanyl commented 3 months ago

@SergK I'm getting error log No configuration found for '2cdf8d8a' at 'null' in 'null', this seems relate to log4j configuration, have you seen the error?

Full log outputs

Reading pipelines and data-prepper configuration files from Data Prepper home directory.
/usr/bin/java
Found openjdk version  of 17.0
2024-06-12T07:48:36.473380208Z main ERROR Reconfiguration failed: No configuration found for '2cdf8d8a' at 'null' in 'null'

SergK commented 3 months ago

@ruanyl yep, fix is on the way in a 20 minutes

SergK commented 3 months ago

@ruanyl I've fixed the issue

SergK commented 3 months ago

fixed ci issue

ruanyl commented 3 months ago

@ruanyl I've fixed the issue

Tried another time and it works fine for me 👍

@TheAlgo Could we get more reviewers on this PR?

peterzhuamazon commented 3 months ago

Thanks @SergK for contribution. Adding @TheAlgo @DandyDeveloper @smlx @prudhvigodithi to take a look.

Thanks.

prudhvigodithi commented 3 months ago

Thanks @SergK I will take the opportunity to review this and we can ship this chart. Thank you

prudhvigodithi commented 3 months ago

Thanks for your contribution @SergK the initial version of the chart LGTM, please add the CHANGELOG.md and README.md files similar to what we have for other charts in this repo. Thanks @getsaurabh02

prudhvigodithi commented 3 months ago

We can move forward with this PR once we have the CHANGELOG.md and README.md files added and also I see no blocker for releasing this helm chart (using https://github.com/opensearch-project/helm-charts/blob/main/.github/workflows/release.yaml) and publishing to https://artifacthub.io/packages/search?org=opensearch-project&sort=relevance&page=1.

SergK commented 3 months ago

@prudhvigodithi done

TheAlgo commented 3 months ago

Thanks @SergK for the contribution and apologies for late review. I will review it sometime today.

prudhvigodithi commented 3 months ago

Hey @TheAlgo following up on this PR, can you please take a look and add your thoughts on the PR? Thank you @getsaurabh02

prudhvigodithi commented 3 months ago

Should we add a CI similar to opensearch and opensearch-dashboards here?

Thanks @TheAlgo yes eventually we need them @SergK.

prudhvigodithi commented 3 months ago

The release is successful https://github.com/opensearch-project/helm-charts/releases/tag/data-prepper-0.1.0

helm search repo opensearch/data-prepper
NAME                    CHART VERSION   APP VERSION DESCRIPTION                  
opensearch/data-prepper 0.1.0           2.8.0       A Helm chart for Data Prepper

Will wait to get the artifacthub updated https://artifacthub.io/packages/search?repo=opensearch-project-helm-charts&sort=relevance&page=1 Thanks @SergK