search

opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
168 stars 228 forks source link

[Enhancement][opensearch] Allow user-defined labels on pvcs #554

Open simonstumpf opened 2 months ago

simonstumpf commented 2 months ago

Is your feature request related to a problem? Please describe. Our PVCs get backuped based on a policy defined in the PVC label. However it's currently not possible to define additional labels for the PVC (instead the global labels are applied if .Values.persistence.labels.enabled is true). Describe the solution you'd like I'd like to define additional labels that are added besides the global labels.

Describe alternatives you've considered I don't see another way of doing it.

Additional context

prudhvigodithi commented 2 months ago

[Triage] I see the PR https://github.com/opensearch-project/helm-charts/pull/555 is already created for this change, thanks for your contribution @simonstumpf.

peterzhuamazon commented 1 week ago

Waiting for the backport to 1.x before closing this.

Thanks.

simonstumpf commented 6 days ago

@peterzhuamazon Thanks! Should I merge my branch into the 1.x branch or the main?

prudhvigodithi commented 6 days ago

Hey @simonstumpf please create a PR to 1.x branch.

simonstumpf commented 5 days ago

@prudhvigodithi Im a little bit confused. I've created the PR, but there are too many changes? Do you see what I did wrong?

prudhvigodithi commented 5 days ago

@simonstumpf you need to clone 1.x--> add your changes-->then please create the PR to 1.x.

peterzhuamazon commented 5 days ago

@prudhvigodithi Im a little bit confused. I've created the PR, but there are too many changes? Do you see what I did wrong?

Added steps here also closed that PR since it is messing up. https://github.com/opensearch-project/helm-charts/pull/599#issuecomment-2358934979

Thanks.