search

opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

[Backport 1.x] Add Service Monitor Resource #578

Closed VILJkid closed 3 weeks ago

VILJkid commented 1 month ago

Description

It would add a prometheus serviceMonitor resource.

Check List

For any changes to files within Helm chart directories:

PR sponsored by Obmondo

prudhvigodithi commented 1 month ago

Thanks @VILJkid should we wait until this fix is pushed https://github.com/opensearch-project/helm-charts/issues/579#issuecomment-2306751619 ? @getsaurabh02 @peterzhuamazon

VILJkid commented 1 month ago

Thanks for the update, @prudhvigodithi! I'll keep an eye on that, and update this PR accordingly.

peterzhuamazon commented 1 month ago

Pending fix:

peterzhuamazon commented 1 month ago

Pending fix:

* [[Fix] OpenSearch and OpenSearch Dashboards Service Monitor Bug #581](https://github.com/opensearch-project/helm-charts/pull/581)

Since this is merged now would you mind update this PR to include above changes? Thanks @VILJkid !

VILJkid commented 1 month ago

Thanks @peterzhuamazon, I'll update this PR with the changes shortly.

VILJkid commented 1 month ago

@peterzhuamazon, kindly review the changes and let me know if it needs any improvement. Thanks!

peterzhuamazon commented 1 month ago

Thanks @VILJkid , adding @prudhvigodithi to take a second pass.

peterzhuamazon commented 4 weeks ago

Waiting for @prudhvigodithi to give a second approval.

Thanks.

prudhvigodithi commented 4 weeks ago

There is a new bug created https://github.com/opensearch-project/helm-charts/issues/588, @VILJkid can you please take a look before we merge this? Thank you

VILJkid commented 4 weeks ago

Thanks @prudhvigodithi, @peterzhuamazon for highlighting the issue. Here's the fix PR: https://github.com/opensearch-project/helm-charts/pull/589 Let me know if it needs any improvements.

peterzhuamazon commented 3 weeks ago

Thanks @prudhvigodithi, @peterzhuamazon for highlighting the issue. Here's the fix PR: #589 Let me know if it needs any improvements.

Thanks @VILJkid I have merged that PR now. Please go ahead and backport the changes here as well.

Thanks!

VILJkid commented 3 weeks ago

Thanks @peterzhuamazon @prudhvigodithi! I've updated this PR accordingly. Kindly review and let me know your thoughts.