search

opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
173 stars 234 forks source link

[Enhancement][opensearch/opensearch-dashboards] ServiceMonitor is missing the ability to add a specific label to it #585

Open eyenx opened 2 months ago

eyenx commented 2 months ago

Is your feature request related to a problem? Please describe. When enabling ServiceMonitor one might need to add a specific label to it to make it scrapable by Prometheus

Describe the solution you'd like Additional serviceMonitor.selector value or extraLabels to add to the serviceMonitor

Describe alternatives you've considered Just adding labels to the global labels value. But this would end up in the deployments and other resources as well.

Additional context I will open up a PR myself.

prudhvigodithi commented 2 months ago

[Triage] Hey @eyenx thanks PR https://github.com/opensearch-project/helm-charts/pull/586, we can take look and get this merged soon. We can 1st get this PR merged https://github.com/opensearch-project/helm-charts/pull/578/files and come back to https://github.com/opensearch-project/helm-charts/pull/586. Thank you @peterzhuamazon @TheAlgo @VILJkid

peterzhuamazon commented 2 months ago

This seems resolved by #586 now, please close the issue once backport is done on 1.x.

Thanks!

eyenx commented 2 months ago

I will backport this to 1.x this week