opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
173 stars 235 forks source link

[Backport 1.x] Fix missing imagePullPolicy on persistence init container #612

Closed anna-intellegens closed 4 days ago

anna-intellegens commented 1 month ago

Description

This fixes an issue where installing the helm chart in an offline environment would fail as the persistence init container would ignore the configured pullPolicy

Issues Resolved

Will fix #611

Check List

For any changes to files within Helm chart directories:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peterzhuamazon commented 2 weeks ago

Hi @anna-intellegens is this change only on 1.x branch? No main branch?

Thanks.

anna-intellegens commented 2 weeks ago

Hi, The main branch appears to have already resolved this issue previously here: https://github.com/opensearch-project/helm-charts/commit/3e6e6a6e4d6e40075e32ba7879faa4e4df7afe79, it just never got back-ported to version 1.

peterzhuamazon commented 1 week ago

Hi, The main branch appears to have already resolved this issue previously here: 3e6e6a6, it just never got back-ported to version 1.

Thanks, will try to merge it today.