opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
173 stars 235 forks source link

Allow security plugin's install_demo_configuration to write to opensearch.yml #620

Closed cwperks closed 3 days ago

cwperks commented 4 days ago

Description

This PR comments out the demo configuration values for the security plugin in values.yaml of the opensearch chart. When a pod is spun up, it runs the install_demo_configuration script which will write these values into opensearch.yml so the helm chart does not need to explicitly include these. Leaving these values in as a comment so users of the chart know what to replace when configuring security.

Tested by modifying the values.yaml of the opensearch chart and ensuring a cluster boots up properly after running:

helm install -f ./charts/opensearch/values.yaml opensearch opensearch/opensearch

Issues Resolved

Resolves: https://github.com/opensearch-project/security/issues/4923

Check List

For any changes to files within Helm chart directories:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks commented 4 days ago

Closing this as duplicate of https://github.com/opensearch-project/helm-charts/pull/618

cwperks commented 4 days ago

Re-opened temporarily to verify CI checks.