search

opensearch-project / index-management-dashboards-plugin

🗃 Manage policies and jobs and automate periodic data operations in OpenSearch Dashboards
https://opensearch.org/docs/latest/im-plugin/index/
Apache License 2.0
16 stars 86 forks source link

Making fit and finish changes for ISM policy & Composable template pages #1150

Closed astute-decipher closed 4 weeks ago

astute-decipher commented 1 month ago

Description

Making fit and finish changes for ISM policy & Composable template pages according to the guidance

Issues Resolved

[List any issues this PR will resolve]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

skumawat2025 commented 1 month ago

LGTM. Gone through the pages offline.

danieldong51 commented 1 month ago

Not sure if it's in scope, but the Delete Modal header and text should be EuiText size="s" in public/pages/Policies/containers/Policies/Policies.tsx (uses public/components/ConfirmationModal/ConfirmationModal.tsx)

Screenshot 2024-08-29 at 11 47 56 AM
danieldong51 commented 1 month ago

Also the Delete Policy in public/pages/PolicyDetails/components/DeleteModal/DeleteModal.tsx text should be EuiText size="s"

Screenshot 2024-08-29 at 11 49 09 AM
danieldong51 commented 1 month ago

Also not sure if in scope, but the Modal header should be small h2's in public/components/JSONModal/JSONModal.tsx:

Screenshot 2024-08-29 at 11 52 17 AM
danieldong51 commented 1 month ago

The Text in public/pages/Policies/components/PolicyEmptyPrompt/PolicyEmptyPrompt.tsx should be small:

Screenshot 2024-08-29 at 12 00 21 PM
opensearch-trigger-bot[bot] commented 4 weeks ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1150-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 44260f640fb141be17a6e673d3242696eec0e1d3
# Push it to GitHub
git push --set-upstream origin backport/backport-1150-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1150-to-2.x.