search

opensearch-project / index-management

🗃 Automate periodic data operations, such as deleting indices at a certain age or performing a rollover at a certain size
https://opensearch.org/docs/latest/im-plugin/index/
Apache License 2.0
53 stars 108 forks source link

Upadte admin credential in integration test #1076

Closed Hailong-am closed 5 months ago

Hailong-am commented 5 months ago

Issue #, if available:

1064

Description of changes:

  1. upadte admin credential in integration test

CheckList:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6270b2c) 74.86% compared to head (30d1825) 74.87%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1076 +/- ## ============================================ + Coverage 74.86% 74.87% +0.01% - Complexity 2808 2810 +2 ============================================ Files 367 367 Lines 16518 16518 Branches 2362 2362 ============================================ + Hits 12366 12368 +2 + Misses 2853 2847 -6 - Partials 1299 1303 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

opensearch-trigger-bot[bot] commented 5 months ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1076-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2a33173a0e24b1dd6d78543d67591d6fd637df33
# Push it to GitHub
git push --set-upstream origin backport/backport-1076-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1076-to-2.x.

bowenlan-amzn commented 5 months ago

@Hailong-am can you manual backport when you got time, thanks!

Hailong-am commented 5 months ago 
git worktree remove ../.worktrees/index-management/backport-2.x

sure, here is the PR https://github.com/opensearch-project/index-management/pull/1084