opensearch-project / index-management

🗃 Automate periodic data operations, such as deleting indices at a certain age or performing a rollover at a certain size
https://opensearch.org/docs/latest/im-plugin/index/
Apache License 2.0
53 stars 108 forks source link

Add vikas as code owner #1097

Closed vikasvb90 closed 5 months ago

vikasvb90 commented 5 months ago

Description of changes:

Adding Vikas as a maintainer

CheckList:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (027509e) 74.90% compared to head (8b3bfbb) 74.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1097 +/- ## ============================================ + Coverage 74.90% 74.95% +0.05% - Complexity 2812 2814 +2 ============================================ Files 367 367 Lines 16522 16522 Branches 2363 2363 ============================================ + Hits 12375 12384 +9 + Misses 2845 2836 -9 Partials 1302 1302 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

r1walz commented 5 months ago

@opensearch-project/admin please update permissions for @vikasvb90. Thanks.

bbarani commented 5 months ago

@vikasvb90 @r1walz Can you update https://github.com/opensearch-project/index-management/blob/main/MAINTAINERS.md as well?

bbarani commented 5 months ago

@vikasvb90 @r1walz Can you update https://github.com/opensearch-project/index-management/blob/main/MAINTAINERS.md as well?

nm, I see it updated as part of this PR. I have added Vikas as maintainer now.

opensearch-trigger-bot[bot] commented 5 months ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1097-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7b3f88ecb25fde1bbbaef7025f3f50697dda5f51
# Push it to GitHub
git push --set-upstream origin backport/backport-1097-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1097-to-2.x.