Closed DarshitChanpura closed 7 months ago
@bowenlan-amzn @r1walz mind reviewing this one?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4d8ef69
) 75.37% compared to head (bc10724
) 75.36%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Related to https://github.com/opensearch-project/index-management/issues/1086
The error:
What went wrong: Execution failed for task ':integTest'.
Upon investigation I discovered that the integration tests triggered by opensearch-build do not pass
security
as an inline argument, instead they passhttps
(code-line). This cause the index-management tests in RC builds runwith-security
to fail withNot a valid SSL/TLS record: NotSslRecordException
which translates to mismatch betweenhttp
vshttps
. The protocol is set here conditionally to https viasecurityEnabled
flag via https://github.com/opensearch-project/index-management/blob/bc10724d39ced73e9f05ab94a554033d338784ce/build.gradle#L514This PR adds an additional check to toggle securityEnabled flag by checking if
https
was passed.CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.