opensearch-project / index-management

🗃 Automate periodic data operations, such as deleting indices at a certain age or performing a rollover at a certain size
https://opensearch.org/docs/latest/im-plugin/index/
Apache License 2.0
52 stars 107 forks source link

Fix Typo in Alias Message #1137

Closed sarthakaggarwal97 closed 3 months ago

sarthakaggarwal97 commented 3 months ago

Issue: #1123

Description of changes: Fixes a small type in the alias message

CheckList:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.35%. Comparing base (a30e4b8) to head (d9db4ad).

:exclamation: Current head d9db4ad differs from pull request most recent head 1bdb23c. Consider uploading reports for the commit 1bdb23c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1137 +/- ## ============================================ - Coverage 75.38% 75.35% -0.03% + Complexity 2813 2811 -2 ============================================ Files 367 367 Lines 17038 17038 Branches 2370 2370 ============================================ - Hits 12844 12839 -5 - Misses 2892 2896 +4 - Partials 1302 1303 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

opensearch-trigger-bot[bot] commented 3 months ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1137-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b80e37214dfcd692bcfcf5dda291d7c4098c0bc2
# Push it to GitHub
git push --set-upstream origin backport/backport-1137-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1137-to-2.x.

r1walz commented 3 months ago

Hi, @sarthakaggarwal97. Thanks for contributing. Would love to see it get backported to 2.x as well. Can you take it up?