Closed harshitakaushik-dev closed 15 hours ago
@bowenlan-amzn @Gaganjuneja @sarthakaggarwal97 @vikasvb90 @r1walz @ankitkala Kindly review the PR. Metrics have been added for 5 more ISM actions. Requested changes in the previous action have been made.
The backport to 2.x
failed:
The process '/usr/bin/git' failed with exit code 128
To backport manually, run these commands in your terminal:
# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1195-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c5425a52e6e7d5fd0f87bf770436527c8911ee08
# Push it to GitHub
git push --set-upstream origin backport/backport-1195-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x
Then, create a pull request where the base
branch is 2.x
and the compare
/head
branch is backport/backport-1195-to-2.x
.
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@bowenlan-amzn I have made the requested changes in the code as per your feedback. Could you kindly review it again? I will add the changes to the tests in the next iteration.
Here are the metrics results we have on Grafana with the OpenTelemetry (Otel) setup. Attached are metrics for Transition Cumulative Latency and Rollover Failure.