Closed heemin32 closed 4 weeks ago
@heemin32 what is potential impact of this bug? Does this need prioritization for 2.16?
Not super critical. The current_size_in_bytes
and total_size_in_bytes
in merge stats will be incorrect.
"graph_stats": {
"merge": {
"current": 0,
"current_docs": 0,
"current_size_in_bytes": 0,
"total_size_in_bytes": 0,
"total": 0,
"total_time_in_millis": 0,
"total_docs": 0
},
"refresh": {
"total": 0,
"total_time_in_millis": 0
}
Forgot to comment on this last week. I'll pick this up later this week, should be a minor change.
I think the logic here is not correct. For example, if the java round up the memory usage by 8 bytes, at least the logic should be
https://github.com/opensearch-project/k-NN/blob/main/src/main/java/org/opensearch/knn/index/codec/util/KNNCodecUtil.java#L94
We need a comment and reference to document to show that the logic is accurate