Open junqiu-lei opened 1 month ago
@junqiu-lei Could you provide context around what changes you are making and why? Itll help for review
@junqiu-lei Could you provide context around what changes you are making and why? Itll help for review
Sure, updated in PR description.
@junqiu-lei Did ./bin/jni_test pass on your local?
@junqiu-lei Did ./bin/jni_test pass on your local?
Yes, here is the results:
[==========] 74 tests from 39 test suites ran. (492 ms total)
[ PASSED ] 74 tests.
(base) junqiu@6c7e67cc15a1 jni % git status
On branch refactor-jni-train
Your branch is up to date with 'junqiu/refactor-jni-train'.
Description
Follow up from https://github.com/opensearch-project/k-NN/pull/1784, this PR refactors
CreateIndexFromTemplate
andTrainIndex
APIs within JNI layer.Related Issues
Closes https://github.com/opensearch-project/k-NN/issues/1846
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.