opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data
https://opensearch.org/docs/latest/search-plugins/knn/index/
Apache License 2.0
152 stars 113 forks source link

Refactor train index and create index from template APIs in JNI layer #1918

Open junqiu-lei opened 1 month ago

junqiu-lei commented 1 month ago

Description

Follow up from https://github.com/opensearch-project/k-NN/pull/1784, this PR refactors CreateIndexFromTemplate and TrainIndex APIs within JNI layer.

Related Issues

Closes https://github.com/opensearch-project/k-NN/issues/1846

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jmazanec15 commented 1 month ago

@junqiu-lei Could you provide context around what changes you are making and why? Itll help for review

junqiu-lei commented 1 month ago

@junqiu-lei Could you provide context around what changes you are making and why? Itll help for review

Sure, updated in PR description.

jmazanec15 commented 1 month ago

@junqiu-lei Did ./bin/jni_test pass on your local?

junqiu-lei commented 1 month ago

@junqiu-lei Did ./bin/jni_test pass on your local?

Yes, here is the results:

[==========] 74 tests from 39 test suites ran. (492 ms total)
[  PASSED  ] 74 tests.
(base) junqiu@6c7e67cc15a1 jni % git status
On branch refactor-jni-train
Your branch is up to date with 'junqiu/refactor-jni-train'.