search

opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data
https://opensearch.org/docs/latest/search-plugins/knn/index/
Apache License 2.0
152 stars 113 forks source link

Removed JDK 11 and 17 version from CI runs #1921

Closed navneet1v closed 1 month ago

navneet1v commented 1 month ago

Description

Removed JDK 11 and 17 version from CI runs as main branch is moved to higher versions of JDK. I didn't make changes in the target and source compatibility because there is some other issues I am seeing for micro-benchmarks module. Will try to resolve it and then raise another PR for the same.

Related Issues

Ref: https://github.com/opensearch-project/k-NN/issues/1729

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jmazanec15 commented 1 month ago

@navneet1v shall we backport or no? Maybe we can leave other versions for BWC, but for CI/sec for 2.x I think jdk 21 is fine

navneet1v commented 1 month ago

@navneet1v shall we backport or no? Maybe we can leave other versions for BWC, but for CI/sec for 2.x I think jdk 21 is fine

No we should not backport. Check this comment from @reta on neural search PR: https://github.com/opensearch-project/neural-search/pull/838#issuecomment-2239972887

reta commented 1 month ago

Correct, JDK-21 baseline is only for 3.x line (aka main)