search

opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data
https://opensearch.org/docs/latest/search-plugins/knn/index/
Apache License 2.0
156 stars 123 forks source link

Refactor KNNVectorFieldType from KNNVectorFieldMapper to a separate class for better readability. #1931

Closed navneet1v closed 3 months ago

navneet1v commented 3 months ago

Description

Refactor KNNVectorFieldType from KNNVectorFieldMapper to a separate class for better readability. This change doesn't change any functionality, it's just Mapper class was becoming too big and refactoring this class out helps reducing the size of the file and things to look at once.

Related Issues

NA

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jmazanec15 commented 3 months ago

@navneet1v did you update the required tests?

navneet1v commented 3 months ago

@jmazanec15 I updated. Still seems some error, let me check

navneet1v commented 3 months ago

Few classes were missed. Fixing them

navneet1v commented 3 months ago

BWC tests are failing because of the version upgrade. @shatejas when we are fixing the BWCs for the 2.17 version?