opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data
https://opensearch.org/docs/latest/search-plugins/knn/index/
Apache License 2.0
156 stars 123 forks source link

Fix mode/comp params so parameter overrides work #2083

Closed jmazanec15 closed 2 months ago

jmazanec15 commented 2 months ago

Description

In #1949, the intention was to allow users to override params when specifying the mode/compression. If this cannot be done, then it will make it wont be possible to tune indexing characteristics when mode is set, and is thus a broken experience. PR fixes this so that users can override params when using mode/compression params.

The main classes are:

  1. KNNVectorFieldMapper
  2. AbstractMethodResolver
  3. KNNMethodContext
  4. MethodComponentContext
  5. EngineResolver
  6. SpaceTypeResolver

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.