opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data
https://opensearch.org/docs/latest/search-plugins/knn/index/
Apache License 2.0
156 stars 123 forks source link

Fix native engine vector format test #2103

Closed VijayanB closed 2 months ago

VijayanB commented 2 months ago

Description

Previosuly we were not creating hnsw file on segment flush for faiss engine. After successfully integrating hnsw file creation, we forgot to update unit test. In this PR, we will confirm that required files are being created based on field type.

Related Issues

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

navneet1v commented 2 months ago

Thanks @VijayanB for making the test tighter. Somehow when integration happened with NativeIndexWriter the update of this test was missed. Good catch. Approving the code. Assuming tests will pass.