[BUG]The `MIN_OVERSAMPLE_FACTOR` is set to `0`.

opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data

https://opensearch.org/docs/latest/search-plugins/knn/index/

Apache License 2.0

156 stars 123 forks source link

[BUG]The `MIN_OVERSAMPLE_FACTOR` is set to `0`. #2112

Closed kolchfa-aws closed 1 month ago

kolchfa-aws commented 1 month ago

What is the bug? The MIN_OVERSAMPLE_FACTOR is currently set as 0 in RescoreContext. If I understand correctly, it should be set to 1. I think setting it to 0 makes it have no effect on this formula.

kkhatua commented 1 month ago

@jmazanec15 ... why didn't the UTs catch this?

jmazanec15 commented 1 month ago

@kkhatua its a ux bug not a functional bug.

jmazanec15 commented 1 month ago

more about experience than breaking