opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data
https://opensearch.org/docs/latest/search-plugins/knn/index/
Apache License 2.0
156 stars 123 forks source link

Added NMSLIB patched allowing load/write APIs with a stream object. #2144

Closed 0ctopus13prime closed 1 month ago

0ctopus13prime commented 1 month ago

Descriptions

This patch adds two new methods in NMSLIB that accepts stream objects to let its internal hnsw can read and write bytes. Which will eventually trigger Lucene’s IndexInput in the PR to be raised.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jmazanec15 commented 1 month ago

Thanks @0ctopus13prime . Can you update the CMake file with this patch so it gets built? See https://github.com/opensearch-project/k-NN/blob/main/DEVELOPER_GUIDE.md#custom-patch-on-jni-library

0ctopus13prime commented 1 month ago

Thanks @0ctopus13prime . Can you update the CMake file with this patch so it gets built? See https://github.com/opensearch-project/k-NN/blob/main/DEVELOPER_GUIDE.md#custom-patch-on-jni-library

Sure, will do in the next revision.