opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data
https://opensearch.org/docs/latest/search-plugins/knn/index/
Apache License 2.0
156 stars 123 forks source link

Update Default Rescore Context based on Dimension #2149

Closed Vikasht34 closed 1 month ago

Vikasht34 commented 1 month ago

Description

This PR contains changes to update oversampling factor in Rescore Context based on Dimension. If Dimension is less than or equal to 1000 then update to 5x Oversampling factor else it will be defaulted to 3x for 32x and 16x compression and 2x for 8x compression.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

naveentatikonda commented 1 month ago

Shouldn't we add an entry in changelog for this change ?

opensearch-trigger-bot[bot] commented 1 month ago

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-2149-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a1227eafe1f539cfb230468c5213e02a015cb8dc
# Push it to GitHub
git push --set-upstream origin backport/backport-2149-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-2149-to-2.17.