[Backport 2.x] Introduce a loading layer in NMSLIB. (#2185)

opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data

https://opensearch.org/docs/latest/search-plugins/knn/index/

Apache License 2.0

156 stars 123 forks source link

[Backport 2.x] Introduce a loading layer in NMSLIB. (#2185) #2220

Closed 0ctopus13prime closed 1 month ago

0ctopus13prime commented 1 month ago

Backport https://github.com/opensearch-project/k-NN/commit/7cf45c8cfd4219912d67becb731f8a7af61410c0 from https://github.com/opensearch-project/k-NN/pull/2185

jmazanec15 commented 1 month ago

@0ctopus13prime can you fix CI/build?

0ctopus13prime commented 1 month ago

@jmazanec15 can you fix CI/build?

Sure, seems like it's a gradle issue from the error message. All failed CI are failed to resolve a dependency of Apache hc package. Could you share how I should deal with this in such case?

  in org.opensearch.knn.TestUtils (TestUtils.java:231)
/Users/runner/work/k-NN/k-NN/src/test/java/org/opensearch/knn/index/KNNCircuitBreakerIT.java:9: error: package org.apache.hc.core5.http.io.entity does not exist

import org.apache.hc.core5.http.io.entity.EntityUtils;

0ctopus13prime commented 1 month ago

Found the root cause for failing. In 2.x, we are using org.apache.http.util.EntityUtils. Will change import statements in the next commit.

-import org.apache.hc.core5.http.io.entity.EntityUtils;
+import org.apache.http.util.EntityUtils;