opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data
https://opensearch.org/docs/latest/search-plugins/knn/index/
Apache License 2.0
156 stars 123 forks source link

Update default engine to FAISS #2221

Closed VijayanB closed 2 weeks ago

VijayanB commented 1 month ago

Description

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

VijayanB commented 1 month ago

Doc issue: https://github.com/opensearch-project/documentation-website/issues/8589

jmazanec15 commented 1 month ago

Can you update this too: https://github.com/opensearch-project/k-NN/blob/main/src/main/java/org/opensearch/knn/index/engine/EngineResolver.java#L51

VijayanB commented 4 weeks ago

Tests are failing not related to this PR. This PR https://github.com/opensearch-project/k-NN/pull/2236 will fix those issue in main. Will rebase once the other PR is merged.

VijayanB commented 2 weeks ago

Test failure is not due to this change.

opensearch-trigger-bot[bot] commented 2 weeks ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2221-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7d3445631591296d00c37ea16351a07ca08ffbd3
# Push it to GitHub
git push --set-upstream origin backport/backport-2221-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2221-to-2.x.

VijayanB commented 2 weeks ago

Failure is due to waiting for this PR to be merged https://github.com/opensearch-project/k-NN/pull/2248