search

opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data
https://opensearch.org/docs/latest/search-plugins/knn/index/
Apache License 2.0
156 stars 123 forks source link

Select index settings based on cluster version #2236

Closed VijayanB closed 3 weeks ago

VijayanB commented 4 weeks ago

Description

With https://github.com/opensearch-project/k-NN/pull/2229 , starting 2.18 no graphs will be built if number of document is less than 15K by using default knn index settings. Hence, select index settings based on cluster version, where starting 2.18 it will have "index.knn.advancend.approximate_threshold" set to 0, and uses old defaults for any other cluster that are before 2.18.

Related Issues

1942

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot[bot] commented 3 weeks ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2236-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cbf90f5a456108fa49ffb85020f3edf7e307420e
# Push it to GitHub
git push --set-upstream origin backport/backport-2236-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2236-to-2.x.