Add dimension validation for BQ

opensearch-project / k-NN

🆕 Find the k-nearest neighbors (k-NN) for your vector data

https://opensearch.org/docs/latest/search-plugins/knn/index/

Apache License 2.0

156 stars 123 forks source link

Add dimension validation for BQ #2269

Open jmazanec15 opened 1 week ago

jmazanec15 commented 1 week ago

Description

Right now, BQ requires that input vectors be divisible by 8. It currently fails silently if the dimension is not divisible by 8. We should validate and reject the configuration if a dimension is passed in that is not divisible by 8.

heemin32 commented 1 week ago

We can pad zero to make it multiple of 8 instead of rejecting it.

vamshin commented 1 week ago

We can pad zero to make it multiple of 8 instead of rejecting it.

makes sense to keep better out-of-box experience.