opensearch-project / logstash-output-opensearch

A Logstash plugin that sends event data to a OpenSearch clusters and stores as an index.
https://opensearch.org/docs/latest/clients/logstash/index/
Apache License 2.0
104 stars 80 forks source link

Release a new docker image for logstash-oss-with-opensearch-output-plugin #230

Open dblock opened 11 months ago

dblock commented 11 months ago

Did you read the on-boarding document

In https://github.com/opensearch-project/logstash-output-opensearch/issues/208 we decided to discontinue the docker distribution of logstash-oss-with-opensearch-output-plugin. However, coming from https://github.com/opensearch-project/logstash-output-opensearch/issues/228#issuecomment-1719180937, we are asking to reverse this decision and release an updated opensearchproject/logstash-oss-with-opensearch-output-plugin docker image.

What is the name of your component?

opensearchproject/logstash-oss-with-opensearch-output-plugin

What is the link to your GitHub repo?

https://github.com/opensearch-project/logstash-output-opensearch/

Targeted release date

Any date possible.

Where should we publish this component?

Docker Hub

What type of artifact(s) will be generated for this component?

opensearchproject/logstash-oss-with-opensearch-output-plugin:latest should be pulling the latest logstash-output-opensearch 2.0.2

Have you completed the required reviews including security reviews, UX reviews?

this is a minor update

Have you on-boarded automated security scanning for the GitHub repo associated with this component?

yes

Additional context

No response

gaiksaya commented 11 months ago

Hi @dblock ,

Is it a new version or you want to re-release https://hub.docker.com/layers/opensearchproject/logstash-oss-with-opensearch-output-plugin/8.9.0/images/sha256-f8e09fbf2b87a2ac58ac5437134b16b1b813a7fe73054c8a61f41097cbcc2092?context=explore ?

steven-cherry commented 11 months ago

Hi @gaiksaya

8.9.0 has version 2.0.1 of the plugin logstash-output-opensearch-2.0.1-java. I need a container with version 2.0.2 version of the plugin included please. Thanks

dblock commented 11 months ago

What @steven-cherry said. I'd like a new version (8.9.?) with plugin 2.0.2.

gaiksaya commented 11 months ago

Thanks! Tagging the maintainers @dlvenable @asifsmohammed @oeyh to get more input since releasing this component also released other artifacts such as tarball, gems. Wanted to know if we need to release it all.

dlvenable commented 11 months ago

@gaiksaya , The Gem is already updated - 2.0.2. So if we perform a release, it will be only the tar.gz/Docker image.

This request is to build a new Logstash tar.gz/Docker image. We are deprecating this image however, and had made our last release the last planned release.

We encourage users to install the plugin on the Elastic Logstash distribution - https://hub.docker.com/r/elastic/logstash.

bbarani commented 11 months ago

@dblock @steven-cherry It looks like there wont be any further Docker release based on the above comment from @dlvenable. Would you be able to work with Gem?

dblock commented 11 months ago

We have customers that we're supporting that are still asking for bug fixes. I wish this process was automated so that we don't have to spend a lot of effort making a release. Am I understanding correctly that this is not the case?

dblock commented 11 months ago

@dlvenable Are we not planning to do high severity security patches either if they are reported?

gaiksaya commented 11 months ago

Moving this to logstash repository until we have a final decision after discussing with repo maintainers. Please feel free to transfer back if we need to proceed/automate this process. Thanks!

dlvenable commented 10 months ago

@dblock , This is correct. We are not releasing updates to the Docker image or the tar.gz file. We are releasing updates to logstash-output-opensearch as Ruby Gems which are available here.

dblock commented 10 months ago

@dblock , This is correct. We are not releasing updates to the Docker image or the tar.gz file. We are releasing updates to logstash-output-opensearch as Ruby Gems which are available here.

So is the docker image EOLed?

dlvenable commented 10 months ago

Yes, the Docker image and the tarball are EOL.

SebastianThorn commented 5 months ago

Yes, the Docker image and the tarball are EOL.

Who can add this information to the description for the public docker-image? It seems to has 30k downloads a week. https://hub.docker.com/r/opensearchproject/logstash-oss-with-opensearch-output-plugin

dblock commented 5 months ago

@SebastianThorn We should. @peterzhuamazon do you know how?

bbarani commented 5 months ago

@dblock @dlvenable @SebastianThorn We can add the below information to the description. Let me know if it looks ok.

DEPRECATION NOTICE: This image is no longer supported / maintained (The image was last updated August 10, 2023). Please read this blog for more information.

dblock commented 5 months ago

Looks good to me! Thanks.

bbarani commented 5 months ago

Looks good to me! Thanks.

done! The deprecation notice has been added to the description now.