Addresses changes made to security demo config install tool

opensearch-project / logstash-output-opensearch

A Logstash plugin that sends event data to a OpenSearch clusters and stores as an index.

https://opensearch.org/docs/latest/clients/logstash/index/

Apache License 2.0

107 stars 80 forks source link

Addresses changes made to security demo config install tool #233

Closed DarshitChanpura closed 7 months ago

DarshitChanpura commented 11 months ago

Description

There were recent changes to security demo configuration setup which now requires a custom admin Password to be setup. This PR updates the documentation and related code change.

Check List

[ ] New functionality includes testing.
- [ ] All tests pass
[ ] New functionality has been documented.
- [ ] New functionality has documentation added
[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

derek-ho commented 11 months ago

@dlvenable this change will be made in 2.12.0. Also myStrongPassword123! is not the new default - it is set as in the env file of this PR. However, I double checked the CI workflow, and it seems like the latest this repo is running is 2.1.0, so I think this PR is not necessary. Please let me know if you agree - if at some point later on this PR starts running CI with 2.12.0 or onwards, there may be changes needed. Otherwise I will close this out.

DarshitChanpura commented 10 months ago

@dlvenable @asifsmohammed @oeyh Can we get some reviews on this? Also, as @derek-ho mentioned, if this PR is not required please feel free to close it.