Support the latest versions of Logstash and the AWS SDK for Ruby.

dlvenable commented 1 month ago

Description

Adds the account_id configuration to the AWSIAMCredential struct to work with the latest versions of the AWS SDK for Ruby. Leaving this as nil should be sufficient because we do not use account-based endpoints.

Test against the latest versions of Logstash during the integration testing to also test against these versions of the AWS SDK. For Logstash 7, this is 7.17.24. For Logstash 8, this is 8.15.3.

The GitHub Actions runners now have docker compose instead of docker-compose, so I also updated all those references.

Issues Resolved

Resolves #258

Check List

[ ] New functionality includes testing.
- [ ] All tests pass
[ ] New functionality has been documented.
- [ ] New functionality has documentation added
[ ] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dblock commented 1 month ago

I assume CI reproduces this without a fix now? If so merge at will, cut a release.

dlvenable commented 1 month ago

@dblock

I ran this first to reproduce locally:

export LOGSTASH_VERSION=7.17.18
scripts/unit-test/docker-setup.sh
scripts/unit-test/docker-run.sh

And the tests failed with the same error from the #258 issue.

This PR uses that same version in the logstash matrix for GitHub Actions. So the CI is verifying the fix.

dblock commented 1 month ago

Thanks so much for fixing this @dlvenable!

weizhu-us commented 1 month ago

confirmed, the plugin works on my local env. Thank you! please let me know when you can cut a release for that.

opensearch-project / logstash-output-opensearch