search

opensearch-project / ml-commons

ml-commons provides a set of common machine learning algorithms, e.g. k-means, or linear regression, to help developers build ML related features within OpenSearch.
Apache License 2.0
95 stars 129 forks source link

[FEATURE] Improve test coverage for MLEngineClassLoader class #1377

Open dhrubo-os opened 1 year ago

dhrubo-os commented 1 year ago

We need to improve test coverage in our repo.

This issue will target only to improve test coverage for MLEngineClassLoader.java class From this url we can see where test coverage is missing for this class: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/ml-algorithms%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fengine%2FMLEngineClassLoader.java

vimalJD commented 1 year ago

Is this project is ongoing? Let me know further (DOCS) to contribute on it as "good first issue".

dhrubo-os commented 1 year ago

This is is created for CCI. Feel free to pick this issue.

Target is to increase the test coverage for this class. We already have some tests here .

We need to extend more tests. So if you have any question related to that, please ask. Thanks

vimalJD commented 1 year ago

This is is created for CCI. Feel free to pick this issue.

Target is to increase the test coverage for this class. We already have some tests here .

We need to extend more tests. So if you have any question related to that, please ask. Thanks

Could you please add me on lable with good first issue

dhrubo-os commented 1 year ago

Sure, assigned it to you.

vimalJD commented 1 year ago

Sure, assigned it to you.

it is not reflected on my repo so by mistake it remove by me clicking on assign tab

vimalJD commented 1 year ago

I have not pulled the above PR yet, because I have been understanding the Docs of the codebase. Do you think it's okay or should I pull it to repo as my fork?

dhrubo-os commented 1 year ago

You can do whenever you are ready to start coding.

dhrubo-os commented 11 months ago

@vimalJD any update on this?